Skip to content

spirv-std: let ray_query! compile on non-SPIR-V targets. - #698

Merged
Firestar99 merged 1 commit into
Rust-GPU:mainfrom
dsvensson:ray-query-host-build
Nov 16, 2026
Merged

Firestar99 merged 1 commit into
Rust-GPU:mainfrom
dsvensson:ray-query-host-build

Conversation

@dsvensson

Copy link
Copy Markdown
Contributor

Lets host type check properly whenever ray_query! is used.

@dsvensson

Copy link
Copy Markdown
Contributor Author

Can trim the comment if you don't see any point in doctest.

@Firestar99 Firestar99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the extra gpu_only function, should hopefully give you a nice backtrace that makes sense

Its SPIR-V `asm!` made every shader crate using it fail to build for the
host. It now panics there when executed, like `gpu_only` functions do.

The doc example doubles as the test, as doctests are built for the host.
@Firestar99
Firestar99 added this pull request to the merge queue Nov 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 16, 2026
@Firestar99
Firestar99 merged commit dc93035 into Rust-GPU:main Nov 16, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants