Repository navigation
spirv-std: let ray_query! compile on non-SPIR-V targets. - #698
Merged
Merged
Conversation
dsvensson
requested review from
Firestar99,
LegNeato and
eddyb
as code owners
November 11, 2026 19:21
Contributor
Author
|
Can trim the comment if you don't see any point in doctest. |
Firestar99
approved these changes
Nov 16, 2026
Firestar99
left a comment
Member
There was a problem hiding this comment.
I like the extra gpu_only function, should hopefully give you a nice backtrace that makes sense
Its SPIR-V `asm!` made every shader crate using it fail to build for the host. It now panics there when executed, like `gpu_only` functions do. The doc example doubles as the test, as doctests are built for the host.
Firestar99
force-pushed
the
ray-query-host-build
branch
from
November 16, 2026 15:12
a72c386 to
02849a5
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets host type check properly whenever
ray_query!is used.